linux-kernel - Re: [PATCH 3/4] PCI: pciehp: Remove unused macro definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190428155536.GU9224@smile.fi.intel.com>
Date:   Sun, 28 Apr 2019 18:55:36 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     fred@...dlawl.com
Cc:     bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, mika.westerberg@...ux.intel.com,
        lukas@...ner.de, keith.busch@...el.com, mr.nuke.me@...il.com,
        liudongdong3@...wei.com, thesven73@...il.com
Subject: Re: [PATCH 3/4] PCI: pciehp: Remove unused macro definitions

On Sat, Apr 27, 2019 at 02:13:03PM -0500, fred@...dlawl.com wrote:
> Now that all uses for the ctrl_*() printk wrappers are removed from
> files and replaces with pci_*() or pr_*() printk wrappers, remove the
> unused macro definitions. In addition to that, remove the MY_NAME macro.

>  extern bool pciehp_debug;

How it's used after all?

> -#define dbg(format, arg...)						\
> -do {									\
> -	if (pciehp_debug)						\
> -		printk(KERN_DEBUG "%s: " format, MY_NAME, ## arg);	\
> -} while (0)

> -#define ctrl_dbg(ctrl, format, arg...)					\
> -	do {								\
> -		if (pciehp_debug)					\
> -			dev_printk(KERN_DEBUG, &ctrl->pcie->device,	\
> -					format, ## arg);		\
> -	} while (0)

Besides ruining the pciehp_debug support this will make unequivalent behaviour.

-- 
With Best Regards,
Andy Shevchenko