linux-kernel - Re: [PATCH 1/6] lib/string: add strnchrnul()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190428192250.GY9224@smile.fi.intel.com>
Date:   Sun, 28 Apr 2019 22:22:50 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yury Norov <yury.norov@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Amritha Nambiar <amritha.nambiar@...el.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Matthew Wilcox <willy@...radead.org>,
        "Tobin C . Harding" <tobin@...nel.org>,
        Will Deacon <will.deacon@....com>,
        Miklos Szeredi <mszeredi@...hat.com>,
        Vineet Gupta <vineet.gupta1@...opsys.com>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Yury Norov <ynorov@...vell.com>, linux-kernel@...r.kernel.org,
        Jens Axboe <axboe@...nel.dk>,
        Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [PATCH 1/6] lib/string: add strnchrnul()

On Sun, Apr 28, 2019 at 11:26:12AM -0700, Yury Norov wrote:
> On Sun, Apr 28, 2019 at 07:04:00PM +0300, Andy Shevchenko wrote:
> > On Sat, Apr 27, 2019 at 08:29:31PM -0700, Yury Norov wrote:
> > > New function works like strchrnul() with a length limited strings.
> > 
> > The prototype better to be consistent with strchrnul() and memchr(), i.e.
> > the size parameter to go last.
>  
> But if so it would be inconsistent with strnchr(). I'm OK to do the change,
> but I'm not sure if this version better than that.

Forgot to check it. In this case, yes, strnchr() + size.

-- 
With Best Regards,
Andy Shevchenko