linux-kernel - Re: [PATCH-tip v7 00/20] locking/rwsem: Rwsem rearchitecture part 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whU83HbayBmOS-jbK7bQJUp87mvAYxhL=vz5wC_ARQCWA@mail.gmail.com>
Date:   Sun, 28 Apr 2019 15:46:07 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Waiman Long <longman@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Will Deacon <will.deacon@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Davidlohr Bueso <dave@...olabs.net>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        huang ying <huang.ying.caritas@...il.com>
Subject: Re: [PATCH-tip v7 00/20] locking/rwsem: Rwsem rearchitecture part 2

This doesn't seem to be the full diff - looking at that patch 1 you
seem to have taken my suggested list_cut_before() change too.

I'm not against it (it does seem to be simpler and better), I just
hope you double-checked it, since I kind of hand-waved it.

                    Linus

On Sun, Apr 28, 2019 at 2:26 PM Waiman Long <longman@...hat.com> wrote:
>
>  v6=>v7 diff
>  -----------
> diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c
> index 97a2334d9cd3..60783267b50d 100644
> --- a/kernel/locking/rwsem.c
> +++ b/kernel/locking/rwsem.c
> @@ -693,7 +693,7 @@ static void __rwsem_mark_wake(struct rw_semaphore *sem,
>                 atomic_long_add(adjustment, &sem->count);
>
>         /* 2nd pass */
> -       list_for_each_entry(waiter, &wlist, list) {
> +       list_for_each_entry_safe(waiter, tmp, &wlist, list) {
>                 struct task_struct *tsk;
>
>                 tsk = waiter->task;
>