linux-kernel - RE: [PATCH] input: imx6ul_tsc: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 28 Apr 2019 06:30:11 +0000
From:   Anson Huang <anson.huang@....com>
To:     Mukesh Ojha <mojha@...eaurora.org>,
        "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] input: imx6ul_tsc: use devm_platform_ioremap_resource()
 to simplify code

Ping...

> -----Original Message-----
> From: Mukesh Ojha [mailto:mojha@...eaurora.org]
> Sent: Monday, April 1, 2019 4:02 PM
> To: Anson Huang <anson.huang@....com>; dmitry.torokhov@...il.com;
> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com; linux-input@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Cc: dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH] input: imx6ul_tsc: use
> devm_platform_ioremap_resource() to simplify code
> 
> 
> On 4/1/2019 10:49 AM, Anson Huang wrote:
> > Use the new helper devm_platform_ioremap_resource() which wraps the
> > platform_get_resource() and devm_ioremap_resource() together, to
> > simplify the code.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> 
> 
> Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>
> 
> Cheers,
> -Mukesh
> 
> > ---
> >   drivers/input/touchscreen/imx6ul_tsc.c | 8 ++------
> >   1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/imx6ul_tsc.c
> > b/drivers/input/touchscreen/imx6ul_tsc.c
> > index c10fc59..e04eecd 100644
> > --- a/drivers/input/touchscreen/imx6ul_tsc.c
> > +++ b/drivers/input/touchscreen/imx6ul_tsc.c
> > @@ -364,8 +364,6 @@ static int imx6ul_tsc_probe(struct platform_device
> *pdev)
> >   	struct device_node *np = pdev->dev.of_node;
> >   	struct imx6ul_tsc *tsc;
> >   	struct input_dev *input_dev;
> > -	struct resource *tsc_mem;
> > -	struct resource *adc_mem;
> >   	int err;
> >   	int tsc_irq;
> >   	int adc_irq;
> > @@ -403,16 +401,14 @@ static int imx6ul_tsc_probe(struct
> platform_device *pdev)
> >   		return err;
> >   	}
> >
> > -	tsc_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	tsc->tsc_regs = devm_ioremap_resource(&pdev->dev, tsc_mem);
> > +	tsc->tsc_regs = devm_platform_ioremap_resource(pdev, 0);
> >   	if (IS_ERR(tsc->tsc_regs)) {
> >   		err = PTR_ERR(tsc->tsc_regs);
> >   		dev_err(&pdev->dev, "failed to remap tsc memory: %d\n",
> err);
> >   		return err;
> >   	}
> >
> > -	adc_mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> > -	tsc->adc_regs = devm_ioremap_resource(&pdev->dev, adc_mem);
> > +	tsc->adc_regs = devm_platform_ioremap_resource(pdev, 1);
> >   	if (IS_ERR(tsc->adc_regs)) {
> >   		err = PTR_ERR(tsc->adc_regs);
> >   		dev_err(&pdev->dev, "failed to remap adc memory: %d\n",
> err);