lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 28 Apr 2019 09:18:40 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Wenwen Wang" <wang6495@....edu>
Cc:     "moderated list:SOUND" <alsa-devel@...a-project.org>,
        "Kees Cook" <keescook@...omium.org>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "open list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usx2y: fix a memory leak bug

On Sun, 28 Apr 2019 08:42:32 +0200,
Wenwen Wang wrote:
> 
> In usX2Y_In04_init(), a new urb is firstly created through usb_alloc_urb()
> and saved to 'usX2Y->In04urb'. Then, a buffer is allocated through
> kmalloc() and saved to 'usX2Y->In04Buf'. After the urb is initialized, a
> sanity check is performed for the endpoint in the urb by invoking
> usb_urb_ep_type_check(). If the check fails, the error code EINVAL will be
> returned. In that case, however, the created urb and the allocated buffer
> are not freed, leading to memory leaks.
> 
> To fix the above issue, free the urb and the buffer if the check fails.
> 
> Signed-off-by: Wenwen Wang <wang6495@....edu>

Applied now, thanks.


Takashi

Powered by blists - more mailing lists