lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Apr 2019 10:58:43 +0300 From: Gilad Ben-Yossef <gilad@...yossef.com> To: Yue Haibing <yuehaibing@...wei.com> Cc: Herbert Xu <herbert@...dor.apana.org.au>, Linux kernel mailing list <linux-kernel@...r.kernel.org>, Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, David Miller <davem@...emloft.net> Subject: Re: [PATCH -next] crypto: ccree - remove set but not used variable 'du_size' On Fri, Apr 26, 2019 at 7:38 PM Yue Haibing <yuehaibing@...wei.com> wrote: > > From: YueHaibing <yuehaibing@...wei.com> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/crypto/ccree/cc_cipher.c: In function cc_setup_key_desc: > drivers/crypto/ccree/cc_cipher.c:645:15: warning: variable du_size set but not used [-Wunused-but-set-variable] > > It is never used since introduction in > commit dd8486c75085 ("crypto: ccree - move key load desc. before flow desc.") > > Signed-off-by: YueHaibing <yuehaibing@...wei.com> > --- > drivers/crypto/ccree/cc_cipher.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c > index d9f8cd5..6bd3791 100644 > --- a/drivers/crypto/ccree/cc_cipher.c > +++ b/drivers/crypto/ccree/cc_cipher.c > @@ -642,16 +642,12 @@ static void cc_setup_key_desc(struct crypto_tfm *tfm, > int direction = req_ctx->gen_ctx.op_type; > dma_addr_t key_dma_addr = ctx_p->user.key_dma_addr; > unsigned int key_len = ctx_p->keylen; > - unsigned int du_size = nbytes; > unsigned int din_size; > > struct cc_crypto_alg *cc_alg = > container_of(tfm->__crt_alg, struct cc_crypto_alg, > skcipher_alg.base); > > - if (cc_alg->data_unit) > - du_size = cc_alg->data_unit; Thanks! This is a good catch. It seems we can also drop the whole cc_alg var as well in this case, since it is only used by the code setting du_size.... Do you want to send a patch doing both or shall I ? Cheers, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker values of β will give rise to dom!
Powered by blists - more mailing lists