linux-kernel - Re: [PATCH 0/7] irqchip: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5574b406-9ef2-bde3-6270-6fbe5d4ad893@arm.com>
Date:   Mon, 29 Apr 2019 09:27:07 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Mukesh Ojha <mojha@...eaurora.org>, tglx@...utronix.de,
        jason@...edaemon.net, yamada.masahiro@...ionext.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] irqchip: Use devm_platform_ioremap_resource()

On 04/04/2019 08:20, Mukesh Ojha wrote:
> Hi All,
> 
> This is just a minor change to promote using of this api
> devm_platform_ioremap_resource() and nothing else functional
> change it does.
> 
> Also, there are patches where only ioremap is used without requesting
> the mem region so this devm_platform_ioremap_resource() take cares all
> of that in single call.

This series has a number of problems:

- It seems to introduce bugs rather than fixing anything
- It doesn't do a complete job of cleaning up the drivers
- Patch 4 does more than it is advertises doing
- You haven't cc'd the authors of these drivers, which would be common
courtesy

For a series that is a "minor change", that's a bit much. Please do not
send such blanket changes without understanding what you are doing.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...