linux-kernel - Re: [PATCH v11 0/7] [media] Add analog mode support for Medion MD95700

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <370e45ab-5534-4e65-5631-5d7a2babcb19@maciej.szmigiero.name>
Date:   Mon, 29 Apr 2019 13:42:30 +0200
From:   "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To:     Hans Verkuil <hverkuil@...all.nl>
Cc:     Michael Krufky <mkrufky@...uxtv.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Andy Walls <awalls@...metrocast.net>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-media@...r.kernel.org
Subject: Re: [PATCH v11 0/7] [media] Add analog mode support for Medion
 MD95700

Hi Hans,

On 29.04.2019 10:17, Hans Verkuil wrote:
> Hi Maciej,
> 
> I reviewed v11 and I had only two comments in two sources. Can you fix that
> and post a v12?

Thanks for looking at this quickly, will do.

> Mike, once v12 is posted, can you try and test it on your hardware?
> 
> The goal is to get this merged for 5.3.
> 
> Maciej, just FYI: I won't merge the last patch. It's OK to post it, that
> way it is archived if anyone is ever interested in this in the future, but
> it's not something that we want to merge. It adds a new public API to enable
> this, and that's not something we'd like to do unless there is a really
> good reason. And adding a debug feature for old hardware isn't enough of a
> reason. Sorry.

:(

I was hoping that maybe something like CONFIG_VIDEO_ADV_DEBUG will do the
trick.

I'm afraid that if this is out-of-tree it will quickly bitrot since people
will submit patches to "optimize" the in-kernel code unknowingly breaking
compatibility with this patch.

But I respect your decision here.

> Regards,
> 
> 	Hans
> 

Thanks,
Maciej