linux-kernel - Re: [RFC PATCH 1/4] fdomain: Resurrect driver (core)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190429115102.GB25365@infradead.org>
Date:   Mon, 29 Apr 2019 04:51:02 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Ondrej Zary <linux@...y.sk>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Rik Faith <faith@...unc.edu>,
        "David A . Hinds" <dahinds@...rs.sourceforge.net>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/4] fdomain: Resurrect driver (core)

On Sun, Apr 28, 2019 at 09:52:31PM +0200, Ondrej Zary wrote:
> On Wednesday 24 April 2019 08:02:12 Christoph Hellwig wrote:
> > > +static void fdomain_work(struct work_struct *work)
> > > +{
> > > +	struct fdomain *fd = container_of(work, struct fdomain, work);
> > > +	struct Scsi_Host *sh = container_of((void *)fd, struct Scsi_Host,
> > > +					    hostdata);
> > 
> > This looks odd.  We should never need a void cast for container_of.
> 
> This cast is present in all drivers involving container_of, struct Scsi_Host and hostdata. hostdata in struct Scsi_Host is defined as "unsigned long hostdata[0]"...

Oh, right - it is the hostdata mess.  Sorry for the noise!