linux-kernel - Re: v5.1-rc7 fails to build on s390x (Re: Linux 5.1-rc7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190429132518.75nlcixs3zgerv6c@kshutemo-mobl1>
Date:   Mon, 29 Apr 2019 16:25:18 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Jason Gunthorpe <jgg@...lanox.com>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: v5.1-rc7 fails to build on s390x (Re: Linux 5.1-rc7)

On Mon, Apr 29, 2019 at 07:21:36AM +0200, Michal Kubecek wrote:
> v5.1-rc7 fails to build on s390x due to
> 
> 		vmf->page = ZERO_PAGE(vmf->vm_start);
> 
> from commit 67f269b37f9b ("RDMA/ucontext: Fix regression with
> disassociate"). This is not a problem on x86_64 where ZERO_PAGE()
> doesn't use its argument but s390 version does.
> 
> I suppose the line should rather read
> 
> 		vmf->page = ZERO_PAGE(vmf->vma->vm_start);
> 
> but I'm just guessing.

I belive it has to be

		vmf->page = ZERO_PAGE(vmf->address);

-- 
 Kirill A. Shutemov