linux-kernel - Re: [RFC PATCH v2] i2c-piix4: Add Hygon Dhyana SMBus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Apr 2019 16:26:17 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Pu Wen <puwen@...on.cn>
Cc:     <bp@...en8.de>, <linux-i2c@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2] i2c-piix4: Add Hygon Dhyana SMBus support

On Sat, 27 Apr 2019 09:07:44 +0800, Pu Wen wrote:
> The Hygon Dhyana CPU has the SMBus device with PCI device ID 0x790b,
> which is the same as AMD CZ SMBus device. So add Hygon Dhyana support
> to the i2c-piix4 driver by using the code path of AMD.
> 
> Signed-off-by: Pu Wen <puwen@...on.cn>
> ---
> v1->v2:
>   - Remove the revision number checking for Hygon SMBus device.
>   - Document the new supported chipset in drivers/i2c/busses/Kconfig
>     and Documentation/i2c/busses/i2c-piix4 as well as in the header
> 	comment of i2c-piix4.c.
> 
>  Documentation/i2c/busses/i2c-piix4 |  2 ++
>  drivers/i2c/busses/Kconfig         |  1 +
>  drivers/i2c/busses/i2c-piix4.c     | 15 +++++++++++----
>  3 files changed, 14 insertions(+), 4 deletions(-)
> (...)

Looks good to me now, thanks.

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support