linux-kernel - Re: [PATCH] kernel: remove the unused device_private_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4iJo6QdDdaXWJCnF3LqO-wSkRcKx1wwWF1h-=q=z2UZdA@mail.gmail.com>
Date:   Mon, 29 Apr 2019 07:45:34 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Jérôme Glisse <jglisse@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel: remove the unused device_private_entry_fault export

On Mon, Apr 29, 2019 at 4:56 AM Christoph Hellwig <hch@....de> wrote:
>
> This export has been entirely unused since it was added more than 1 1/2
> years ago.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  kernel/memremap.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/memremap.c b/kernel/memremap.c
> index 4e59d29245f4..1490e63f69a9 100644
> --- a/kernel/memremap.c
> +++ b/kernel/memremap.c
> @@ -45,7 +45,6 @@ vm_fault_t device_private_entry_fault(struct vm_area_struct *vma,
>          */
>         return devmem->page_fault(vma, addr, page, flags, pmdp);
>  }
> -EXPORT_SYMBOL(device_private_entry_fault);
>  #endif /* CONFIG_DEVICE_PRIVATE */

Looks good to me.

Reviewed-by: Dan Williams <dan.j.williams@...el.com>