linux-kernel - Re: [GIT PULL] Please pull rdma.git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiYHXxkHrbDACc1-5bqJPuiMnmwbStSYBYo82zsO=gstQ@mail.gmail.com>
Date:   Mon, 29 Apr 2019 09:48:18 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Doug Ledford <dledford@...hat.com>
Cc:     linux-rdma <linux-rdma@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "Gunthorpe, Jason" <jgg@...pe.ca>
Subject: Re: [GIT PULL] Please pull rdma.git

On Mon, Apr 29, 2019 at 9:29 AM Doug Ledford <dledford@...hat.com> wrote:
>
>
>  drivers/infiniband/core/uverbs_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This trivial one-liner is actually incorrect.

It should use 'vmf->address', because the point of the ZERO_PAGE
argument is to pick the page with the right virtual address alias for
broken architectures that need those kinds.

I'm actually surprised s390 wants it, usually it's just MIPS that has
the horribly broken virtual address translation stuff. But it looks
like for s390 it's at least only a performance issue (ie it causes
some aliases in L1 that cause cacheline ping-pong rather than anything
else).

                 Linus