linux-kernel - Re: [PATCH v1 00/14] usb: dwc2: Fix and improve power saving modes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Apr 2019 10:43:15 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Artur Petrosyan <Arthur.Petrosyan@...opsys.com>
Cc:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        John Youn <John.Youn@...opsys.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 00/14] usb: dwc2: Fix and improve power saving modes.

Hi,

On Mon, Apr 29, 2019 at 5:05 AM Artur Petrosyan
<Arthur.Petrosyan@...opsys.com> wrote:
>
> > To add a bit of breadcrumbs, I did the rebase atop my patches and also
> > did some basic review of yours.  Other than a few nits I think I found
> > at least one bug where you're unlocking a spinlock twice in the
> > partial power down case.
> Yeah thank you so much for the review it really helps to make
> conclusions on the implementations. I have tested those patches on
> HAPS-DX platform and have not got any problem. Hibernation and partial
> power down flows are working ok.

Do you happen to have any boards that have "OTG_EN_PWROPT = 0"?  I'd
love testing of my patch series with that.


> > I continue to be convinced that the right thing to do is to finish
> > landing my series and then once you've spun yours atop mine we can
> > look at landing it.
> >
> > Here's all my picks atop Felipe's tree that show how I resolved
> > things:  https://urldefense.proofpoint.com/v2/url?u=https-3A__chromium.googlesource.com_chromiumos_third-5Fparty_kernel_-2Blog_refs_sandbox_dianders_190426-2Ddwc2-2Dstuff&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=9hPBFKCJ_nBjJhGVrrlYOeOQjP_HlVzYqrC_D7niMJI&m=mdz-R9O5TUR_zXEeeCZO2341dvcwZro2cedCZzIIans&s=mVfBGtiMQg2XVHXmGCWcd584g0DYRH1JDVnEnJWE6P8&e=
> >
> >
> > -Doug
> >
>
> I will make my changes then will go ahead and rebase.

Thanks!


-Doug