linux-kernel - Re: [PATCH] firmware_loader: Fix a typo ("syfs" -> "sysfs")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a87e799e-73d3-6971-2df5-59ba34fb1446@codeaurora.org>
Date:   Tue, 30 Apr 2019 20:44:17 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-kernel@...r.kernel.org
Cc:     Colin Ian King <colin.king@...onical.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] firmware_loader: Fix a typo ("syfs" -> "sysfs")


On 4/30/2019 8:26 PM, Jonathan Neuschäfer wrote:
> "sysfs" was misspelled in a comment and a log message.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh
> ---
>   drivers/base/firmware_loader/fallback.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c
> index b5c865fe263b..f962488546b6 100644
> --- a/drivers/base/firmware_loader/fallback.c
> +++ b/drivers/base/firmware_loader/fallback.c
> @@ -674,8 +674,8 @@ static bool fw_run_sysfs_fallback(enum fw_opt opt_flags)
>    *
>    * This function is called if direct lookup for the firmware failed, it enables
>    * a fallback mechanism through userspace by exposing a sysfs loading
> - * interface. Userspace is in charge of loading the firmware through the syfs
> - * loading interface. This syfs fallback mechanism may be disabled completely
> + * interface. Userspace is in charge of loading the firmware through the sysfs
> + * loading interface. This sysfs fallback mechanism may be disabled completely
>    * on a system by setting the proc sysctl value ignore_sysfs_fallback to true.
>    * If this false we check if the internal API caller set the @FW_OPT_NOFALLBACK
>    * flag, if so it would also disable the fallback mechanism. A system may want
> @@ -693,7 +693,7 @@ int firmware_fallback_sysfs(struct firmware *fw, const char *name,
>   		return ret;
>
>   	if (!(opt_flags & FW_OPT_NO_WARN))
> -		dev_warn(device, "Falling back to syfs fallback for: %s\n",
> +		dev_warn(device, "Falling back to sysfs fallback for: %s\n",
>   				 name);
>   	else
>   		dev_dbg(device, "Falling back to sysfs fallback for: %s\n",
> --
> 2.20.1
>