linux-kernel - Re: [PATCH] ACPI / property: fix handling of data_nodes in acpi_get_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Apr 2019 19:47:44 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     linux-acpi@...r.kernel.org,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH] ACPI / property: fix handling of data_nodes in
 acpi_get_next_subnode()

On Tue, Apr 30, 2019 at 11:41:50AM -0500, Pierre-Louis Bossart wrote:
> On 4/30/19 11:30 AM, Andy Shevchenko wrote:
> > On Tue, Apr 30, 2019 at 10:52:29AM -0500, Pierre-Louis Bossart wrote:
> > > When the DSDT tables expose devices with subdevices and a set of
> > > hierarchical _DSD properties, the data returned by
> > > acpi_get_next_subnode() is incorrect, with the results suggesting a bad
> > > pointer assignment. The parser works fine with device_nodes or
> > > data_nodes, but not with a combination of the two.
> > > 
> > > The problem is traced to an invalid pointer used when jumping from
> > > handling device_nodes to data nodes. The existing code looks for data
> > > nodes below the last subdevice found instead of the common root. Fix
> > > by forcing the acpi_device pointer to be derived from the same fwnode
> > > for the two types of subnodes.
> > > 
> > > This same problem of handling device and data nodes was already fixed
> > > in a similar way by 'commit bf4703fdd166 ("ACPI / property: fix data
> > > node parsing in acpi_get_next_subnode()")' but broken later by 'commit
> > > 34055190b19 ("ACPI / property: Add fwnode_get_next_child_node()")', so
> > > this should probably go to linux-stable all the way to 4.12
> > 
> > Period is missed in above sentence.
> > 
> > I think it make sense to add Fixes: tag.
> 
> Thanks Andy for the review. I hesitated to add a fixes tag. The line about
> resetting the adev pointer was indeed removed in the latter commit, but
> there were a slew of other changes done later by Sakari on hierarchical _DSD
> so it's quite complicated to say when this was last fully functional.

I see, btw, you forgot to add Sakari to Cc list, he is doing a lot lately WRT
device properties.

> > Nevertheless,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > 
> > Thank you for fixing this interesting issue!

-- 
With Best Regards,
Andy Shevchenko