linux-kernel - Re: [PATCH] dma-buf: add struct dma_buf_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acaa403e-ad0f-dcf5-bccb-6b7331381889@oracle.com>
Date:   Tue, 30 Apr 2019 12:59:23 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Christian König <ckoenig.leichtzumerken@...il.com>,
        xen-devel@...ts.xenproject.org, devel@...verdev.osuosl.org,
        linux-tegra@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-media@...r.kernel.org, sstabellini@...nel.org,
        jgross@...e.com, digetx@...il.com, gregkh@...uxfoundation.org,
        arnd@...db.de, mchehab@...nel.org, kyungmin.park@...sung.com,
        m.szyprowski@...sung.com, pawel@...iak.com, jonathanh@...dia.com,
        thierry.reding@...il.com, tomi.valkeinen@...com,
        rodrigo.vivi@...el.com, joonas.lahtinen@...ux.intel.com,
        jani.nikula@...ux.intel.com, sean@...rly.run,
        maxime.ripard@...tlin.com, maarten.lankhorst@...ux.intel.com,
        linux@...linux.org.uk, sumit.semwal@...aro.org
Subject: Re: [PATCH] dma-buf: add struct dma_buf_attach_info v2

On 4/30/19 7:10 AM, Christian König wrote:
> diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c
> index 2c4f324f8626..cacca830b482 100644
> --- a/drivers/xen/gntdev-dmabuf.c
> +++ b/drivers/xen/gntdev-dmabuf.c
> @@ -608,6 +608,7 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev,
>  		   int fd, int count, int domid)
>  {
>  	struct gntdev_dmabuf *gntdev_dmabuf, *ret;
> +	struct dma_buf_attach_info attach_info;
>  	struct dma_buf *dma_buf;
>  	struct dma_buf_attachment *attach;
>  	struct sg_table *sgt;
> @@ -627,6 +628,9 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev,
>  	gntdev_dmabuf->priv = priv;
>  	gntdev_dmabuf->fd = fd;
>  
> +	memset(&attach_info, 0, sizeof(attach_info));
> +	attach_info.dev = dev;
> +	attach_info.dmabuf = dma_buf;
>  	attach = dma_buf_attach(dma_buf, dev);
>  	if (IS_ERR(attach)) {
>  		ret = ERR_CAST(attach);

This won't build.

Did you mean

    attach = dma_buf_attach(&attach_info);

?

-boris