linux-kernel - Re: [PATCH] clk: imx: clk-pllv3: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d0d12ae-ce67-5480-49be-893fbdbb6998@embeddedor.com>
Date:   Tue, 30 Apr 2019 12:28:32 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Stephen Boyd <sboyd@...nel.org>,
        Fabio Estevam <festevam@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>
Cc:     linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: imx: clk-pllv3: mark expected switch fall-throughs



On 4/30/19 12:22 PM, Stephen Boyd wrote:
> Quoting Gustavo A. R. Silva (2019-04-30 07:32:06)
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> drivers/clk/imx/clk-pllv3.c: In function ‘imx_clk_pllv3’:
>> drivers/clk/imx/clk-pllv3.c:446:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    pll->div_shift = 1;
>>    ~~~~~~~~~~~~~~~^~~
>> drivers/clk/imx/clk-pllv3.c:447:2: note: here
>>   case IMX_PLLV3_USB:
>>   ^~~~
>> drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
>>                      ^
>> drivers/clk/imx/clk-pllv3.c:454:2: note: here
>>   case IMX_PLLV3_AV:
>>   ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> It was sent by Anson already.
> 

Did he address both warnings?

Thanks
--
Gustavo