lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 30 Apr 2019 14:34:06 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>, <pavel@....cz>
CC:     <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/7] leds: TI LMU: Add common code for TI LMU devices

Jacek

On 4/30/19 2:32 PM, Jacek Anaszewski wrote:
> On 4/30/19 9:30 PM, Dan Murphy wrote:
>> Randy
>>
>> On 4/30/19 2:23 PM, Randy Dunlap wrote:
>>> On 4/30/19 12:17 PM, Dan Murphy wrote:
>>>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>>>> index da00b9ed5a5c..3ae24eaf4cde 100644
>>>> --- a/drivers/leds/Kconfig
>>>> +++ b/drivers/leds/Kconfig
>>>> @@ -776,6 +776,14 @@ config LEDS_NIC78BX
>>>>         To compile this driver as a module, choose M here: the module
>>>>         will be called leds-nic78bx.
>>>>   +config LEDS_TI_LMU_COMMON
>>>> +    tristate "LED driver for TI LMU"
>>>
>>> what does LMU mean?
>>
>> Lighting management unit it is defined in the DT documentation
>>
>>>
>>>> +    depends on REGMAP
>>>> +    help
>>>> +          Say Y to enable the LED driver for TI LMU devices.
>>>> +          This supports common features between the TI LM3532, LM3631, LM3632,
>>>> +      LM3633, LM3695 and LM3697.
>>>
>>> Fix help indentation above to use tab + 2 spaces consistently.
>>>
>>
>> UGH I wish I had this comment 2 weeks ago.
>> But I can fix it
> 
> I will amend this while merging, no need to resend.
> 

Thank you.  I will wait to rebase/repost the LM36274 patchset until after the this series is merged.

Honestly the only change to the LM36274 patchset is adding Rob's RB to the dt patches and rebasing the Kconfig.

Dan

Powered by blists - more mailing lists