linux-kernel - Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Apr 2019 12:51:59 -0700
From:   Matthew Garrett <mjg59@...gle.com>
To:     Bartosz Szczepanek <bsz@...ihalf.com>
Cc:     linux-integrity <linux-integrity@...r.kernel.org>,
        Peter Huewe <peterhuewe@....de>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Roberto Sassu <roberto.sassu@...wei.com>,
        linux-efi <linux-efi@...r.kernel.org>,
        LSM List <linux-security-module@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thiébaud Weksteen <tweek@...gle.com>
Subject: Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table

On Tue, Apr 30, 2019 at 6:07 AM Bartosz Szczepanek <bsz@...ihalf.com> wrote:
>
> I may be a little late with this comment, but I've just tested these
> patches on aarch64 platform (from the top of jjs/master) and got
> kernel panic ("Unable to handle kernel read", full log at the end of
> mail). I think there's problem with below call to
> tpm2_calc_event_log_size(), where physical address of efi.tpm_log is
> passed as (void *) and never remapped:

Yes, it looks like this is just broken. Can you try with the attached patch?

View attachment "fix_log.diff" of type "text/x-patch" (4414 bytes)