linux-kernel - Re: [PATCH 1/4] mtd: rawnand: Turn the ONFI support to generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190430083059.629e0bf1@xps13>
Date:   Tue, 30 Apr 2019 08:30:59 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@...ron.com>
Cc:     Boris Brezillon <bbrezillon@...nel.org>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        "Marek Vasut" <marek.vasut@...il.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Frieder Schrempf <frieder.schrempf@...tron.de>
Subject: Re: [PATCH 1/4] mtd: rawnand: Turn the ONFI support to generic

Hi Shivamurthy,

Sorry for the long delay I was a bit overloaded.

"Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@...ron.com> wrote on
Tue, 26 Mar 2019 10:51:47 +0000:

> Fix headers to make way for adding helper functions.
> 
> Add onfi helper structure.
> 
> Add helper functions in raw NAND core, which later will be used during
> ONFI detection.
> 

As you are touching the core, I need to identify clearly each change
you make; typically in this commit you do several different changes.
Please split this patch in small meaningful peaces.

> Signed-off-by: Shivamurthy Shastri <sshivamurthy@...ron.com>
> ---
>  drivers/mtd/nand/raw/internals.h |   6 +-
>  drivers/mtd/nand/raw/nand_base.c | 236 ++++++++++++++++++++++++++++---
>  drivers/mtd/nand/raw/nand_onfi.c | 215 +++++-----------------------
>  include/linux/mtd/nand.h         |  30 ++++
>  include/linux/mtd/rawnand.h      |   5 +
>  5 files changed, 289 insertions(+), 203 deletions(-)
> 

Thanks,
Miquèl