lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Apr 2019 09:51:08 +0200 From: Jessica Yu <jeyu@...nel.org> To: Prarit Bhargava <prarit@...hat.com> Cc: Heiko Carstens <heiko.carstens@...ibm.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] kernel/module: Reschedule while waiting for modules to finish loading +++ Prarit Bhargava [29/04/19 11:17 -0400]: >Heiko, do you want a Signed-off-by or a Reported-by? Either one works >for me. > >P. I think you forgot to CC Heiko :) >----8<---- > >On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while >loading the s390_trng.ko module. > >Add a reschedule point to the loop that waits for modules to complete >loading. > >Reported-by: Heiko Carstens <heiko.carstens@...ibm.com> >Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading") >Signed-off-by: Prarit Bhargava <prarit@...hat.com> >Cc: Jessica Yu <jeyu@...nel.org> >--- > kernel/module.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/kernel/module.c b/kernel/module.c >index 410eeb7e4f1d..48748cfec991 100644 >--- a/kernel/module.c >+++ b/kernel/module.c >@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod) > finished_loading(mod->name)); > if (err) > goto out_unlocked; >+ cond_resched(); > goto again; > } > err = -EEXIST; >-- >2.18.1 >
Powered by blists - more mailing lists