[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <mhng-42e98065-6d8f-455c-97d9-0a2dfccc731a@palmer-si-x1e>
Date: Mon, 29 Apr 2019 17:36:51 -0700 (PDT)
From: Palmer Dabbelt <palmer@...ive.com>
To: Christoph Hellwig <hch@...radead.org>
CC: atish.patra@....com, linux-kernel@...r.kernel.org,
aou@...s.berkeley.edu, dmitriy@...-tech.org, anup@...infault.org,
johan@...nel.org, Christoph Hellwig <hch@...radead.org>,
Paul Walmsley <paul.walmsley@...ive.com>, schwab@...e.de,
linux-riscv@...ts.infradead.org, tglx@...utronix.de
Subject: Re: [PATCH v3 1/3] RISC-V: Add RISC-V specific arch_match_cpu_phys_id
On Tue, 23 Apr 2019 23:21:00 PDT (-0700), Christoph Hellwig wrote:
>> }
>> +
>> +bool arch_match_cpu_phys_id(int cpu, u64 phys_id)
>> +{
>> + return phys_id == cpuid_to_hartid_map(cpu);
>> +}
>> /* Unsupported */
>
> Please keep an empty line after function bodys.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@....de>
Oh, sorry, I missed this -- I just fixed up the patch and added your tag.
Powered by blists - more mailing lists