linux-kernel - Re: [RESEND PATCH] chardev: set variable ret to -EBUSY before checking minor range overlap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190430083206.GA2239@kadam>
Date:   Tue, 30 Apr 2019 11:32:06 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Chengguang Xu <cgxu519@....com>
Cc:     gregkh@...uxfoundation.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] chardev: set variable ret to -EBUSY before
 checking minor range overlap

Please don't say RESEND, say [PATCH v2].  RESEND is for when we ignored
your patch.  (Maybe we made a mistake or maybe the mailing list tagged
it as spam and deleted it or something).  Use [PATCH v2] instead.

On Fri, Apr 26, 2019 at 03:38:37PM +0800, Chengguang Xu wrote:
> When allocating dynamic major, the minor range overlap check
> in __register_chrdev_region() will not fail, so actually
> there is no real case to passing non negative error code to
> caller. However, set variable ret to -EBUSY before chekcking
> minor range overlap will avoid false-positive warning from
> code analyzing tool(like Smatch) and also make the code more
> easy to understand.
> 
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Chengguang Xu <cgxu519@....com>
> ---

Then here under the --- cut off line put:

v2: rebase against the latest linux-next

That way we will remember why the patch was sent twice and what changed.

>  fs/char_dev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

regards,
dan carpenter