lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 30 Apr 2019 12:38:08 +0300
From:   Cyrill Gorcunov <>
To:     Kirill Tkhai <>
Cc:     Michal Koutný <>,,,,,,,,,,,
Subject: Re: [PATCH 1/3] mm: get_cmdline use arg_lock instead of mmap_sem

On Tue, Apr 30, 2019 at 12:09:57PM +0300, Kirill Tkhai wrote:
> This looks OK for me.
> But speaking about existing code it's a secret for me, why we ignore arg_lock
> in binfmt code, e.g. in load_elf_binary().

Well, strictly speaking we probably should but you know setup of
the @arg_start by kernel's elf loader doesn't cause any side
effects as far as I can tell (its been working this lockless
way for years, mmap_sem is taken later in the loader code).
Though for consistency sake we probably should set it up
under the spinlock.

Powered by blists - more mailing lists