linux-kernel - Re: [PATCH] appletalk: Set error code while register_snap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1fdc9c5-ec67-20af-15c6-7e966c2b65e1@huawei.com>
Date:   Tue, 30 Apr 2019 19:30:59 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <davem@...emloft.net>, <gregkh@...uxfoundation.org>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] appletalk: Set error code while register_snap_client

patch title need fix, Pls ignore this.

On 2019/4/30 19:28, YueHaibing wrote:
> If register_snap_client fails in atalk_init,
> error code should be set, otherwise it will
> triggers NULL pointer dereference while unloading
> module.
> 
> Fixes: 9804501fa122 ("appletalk: Fix potential NULL pointer dereference in unregister_snap_client")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  net/appletalk/ddp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
> index 709d254..dbe8b19 100644
> --- a/net/appletalk/ddp.c
> +++ b/net/appletalk/ddp.c
> @@ -1920,6 +1920,7 @@ static int __init atalk_init(void)
>  	ddp_dl = register_snap_client(ddp_snap_id, atalk_rcv);
>  	if (!ddp_dl) {
>  		pr_crit("Unable to register DDP with SNAP.\n");
> +		rc = -ENOMEM;
>  		goto out_sock;
>  	}
>  
>