lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190430012328.GA25660@bogus> Date: Mon, 29 Apr 2019 20:23:28 -0500 From: Rob Herring <robh@...nel.org> To: Douglas Anderson <dianders@...omium.org> Cc: Minas Harutyunyan <hminas@...opsys.com>, Felipe Balbi <felipe.balbi@...ux.intel.com>, heiko@...ech.de, Alan Stern <stern@...land.harvard.edu>, Artur Petrosyan <Arthur.Petrosyan@...opsys.com>, amstan@...omium.org, linux-rockchip@...ts.infradead.org, William Wu <william.wu@...k-chips.com>, linux-usb@...r.kernel.org, Stefan Wahren <stefan.wahren@...e.com>, Randy Li <ayaka@...lik.info>, zyw@...k-chips.com, mka@...omium.org, ryandcase@...omium.org, Amelie Delaunay <amelie.delaunay@...com>, jwerner@...omium.org, dinguyen@...nsource.altera.com, Elaine Zhang <zhangqing@...k-chips.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Mark Rutland <mark.rutland@....com> Subject: Re: [PATCH v2 3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB On Wed, Apr 17, 2019 at 05:13:54PM -0700, Douglas Anderson wrote: > Some SoCs with a dwc2 USB controller may need to keep the PHY on to > support remote wakeup. Allow specifying this as a device tree > property. > > Signed-off-by: Douglas Anderson <dianders@...omium.org> > --- > For relevant prior discussion on this patch, see: > > https://lkml.kernel.org/r/1435017144-2971-3-git-send-email-dianders@chromium.org > > I didn't make any changes from the prior version since I never found > out what Rob thought of my previous arguments. If folks want a > change, perhaps they could choose from these options: > > 1. Assume that all dwc2 hosts would like to keep their PHY on for > suspend if there's a USB wakeup enabled, thus we totally drop this > binding. This doesn't seem super great to me since I'd bet that > many devices that use dwc2 weren't designed for USB wakeup (they > may not keep enough clocks or rails on) so we might be wasting > power for nothing. 1b. Use SoC specific compatible strings to enable/disable remote wake-up. We can debate what the default is I guess. > 2. Rename this property to "snps,wakeup-from-suspend-with-phy" to make > it more obvious that this property is intended both to document > that wakeup from suspend is possible and that we need the PHY for > said wakeup. > 3. Rename this property to "snps,can-wakeup-from-suspend" and assume > it's implicit that if we can wakeup from suspend that we need to > keep the PHY on. If/when someone shows that a device exists using > dwc2 where we can wakeup from suspend without the PHY they can add > a new property. > > Changes in v2: None > > Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++ > 1 file changed, 3 insertions(+) >
Powered by blists - more mailing lists