linux-kernel - RE: linux-next: build warning after merge of the clk tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB3916B4CE00494BE730C07047F53A0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Tue, 30 Apr 2019 01:44:58 +0000
From:   Anson Huang <anson.huang@....com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Mike Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
CC:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Kees Cook <keescook@...omium.org>
Subject: RE: linux-next: build warning after merge of the clk tree

Hi, Stephen
	Thanks for notice.
	As it is intentional, I will send out a patch to add "/* fall through */" to avoid this build warning,

Anson.

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@...b.auug.org.au]
> Sent: Tuesday, April 30, 2019 8:20 AM
> To: Mike Turquette <mturquette@...libre.com>; Stephen Boyd
> <sboyd@...nel.org>
> Cc: Linux Next Mailing List <linux-next@...r.kernel.org>; Linux Kernel Mailing
> List <linux-kernel@...r.kernel.org>; Anson Huang <anson.huang@....com>;
> Gustavo A. R. Silva <gustavo@...eddedor.com>; Kees Cook
> <keescook@...omium.org>
> Subject: linux-next: build warning after merge of the clk tree
> 
> Hi all,
> 
> After merging the clk tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [-
> Wimplicit-fallthrough=]
>    pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
>                      ^
> drivers/clk/imx/clk-pllv3.c:454:2: note: here
>   case IMX_PLLV3_AV:
>   ^~~~
> 
> Introduced by commit
> 
>   01d0a541ff4b ("clk: imx: correct i.MX7D AV PLL num/denom offset")
> 
> I get this warning because I am building with -Wimplicit-fallthrough in
> attempt to catch new additions early.  The gcc warning can be turned off by
> adding a /* fall through */ comment at the point the fall through happens
> (assuming that the fall through is intentional).
> 
> --
> Cheers,
> Stephen Rothwell