linux-kernel - Re: [PATCH] quota: set init_needed flag only when successfully getting dquot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d005f7a-0e5b-57a5-44d4-83b12fdfa9e9@gmx.com>
Date:   Tue, 30 Apr 2019 10:27:15 +0800
From:   cgxu519 <cgxu519@....com>
To:     Jan Kara <jack@...e.cz>
Cc:     jack@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] quota: set init_needed flag only when successfully
 getting dquot

On 4/30/19 5:49 AM, Jan Kara wrote:
> On Sun 28-04-19 13:39:21, Chengguang Xu wrote:
>> Set init_needed flag only when successfully getting dquot,
>> so that we can skip unnecessary subsequent operation.
>>
>> Signed-off-by: Chengguang Xu <cgxu519@....com>
> Thanks for the patch but I don't think it's really useful. It will be very
> rare that we race with quotaoff of dqget() fails due to error. So the
> additional overhead of iterating over dquots doesn't really matter in that
> case.

Hi Jan,

Thanks for the comment, I got it.

Chengguang.