linux-kernel - Re: [PATCH V2] staging: fieldbus: anybus-s: force endiannes annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190430140339.GA18986@kroah.com>
Date:   Tue, 30 Apr 2019 16:03:39 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     Al Viro <viro@...iv.linux.org.uk>, devel@...verdev.osuosl.org,
        Nicholas Mc Guire <der.herr@...r.at>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nicholas Mc Guire <hofrat@...dl.org>
Subject: Re: [PATCH V2] staging: fieldbus: anybus-s: force endiannes
 annotation

On Tue, Apr 30, 2019 at 09:32:20AM -0400, Sven Van Asbroeck wrote:
> On Tue, Apr 30, 2019 at 12:19 AM Al Viro <viro@...iv.linux.org.uk> wrote:
> >
> > ... not that there's much sense keeping ->fieldbus_type in host-endian,
> > while we are at it.
> 
> Interesting! Suppose we make device->fieldbus_type bus-endian.

Keep it bus-endian, as that's the "normal" way bus structures work (like
PCI and USB for example), and that should be in a documented, and
consistent, form, right?

Then do the conversion when you access the field from within the kernel.
Again, examples of USB and PCI can be used if you want to copy what they
do.

thanks,

greg k-h