linux-kernel - Re: [tip:x86/fpu] x86/fpu: Fault-in user stack if copy_fpstate_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb41f0b7-ed04-a405-0afb-cf72359c4da6@intel.com>
Date:   Tue, 30 Apr 2019 07:20:21 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     jannh@...gle.com, bp@...e.de, riel@...riel.com,
        bigeasy@...utronix.de, linux-kernel@...r.kernel.org, hpa@...or.com,
        pbonzini@...hat.com, tglx@...utronix.de, kvm@...r.kernel.org,
        luto@...capital.net, kurt.kanzenbach@...utronix.de, x86@...nel.org,
        mingo@...nel.org, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/fpu] x86/fpu: Fault-in user stack if
 copy_fpstate_to_sigframe() fails

On 4/29/19 11:52 AM, tip-bot for Sebastian Andrzej Siewior wrote:
> Instead of utilizing copy_xstate_to_user(), fault-in the user memory
> and retry the fast path. Ideally, the fast path succeeds on the second
> attempt but may be retried again if the memory is swapped out due
> to memory pressure. If the user memory can not be faulted-in then
> get_user_pages() returns an error so we don't loop forever.
> 
> Fault in memory via get_user_pages() so copy_fpregs_to_sigframe()
> succeeds without a fault.

Thanks for reworking this.  It looks great.

Acked-by: Dave Hansen <dave.hansen@...el.com>