linux-kernel - Re: [PATCH] ACPI: event: replace strcpy() by strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3853797.yZSUUGEqGl@kreacher>
Date:   Wed, 01 May 2019 12:12:35 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: event: replace strcpy() by strscpy()

On Monday, April 22, 2019 6:39:34 PM CEST Gustavo A. R. Silva wrote:
> The strcpy() function is being deprecated. Replace it by the safer
> strscpy() and fix the following Coverity warnings:
> 
> "You might overrun the 15-character fixed-size string event->bus_id
> by copying bus_id without checking the length."
> 
> "You might overrun the 20-character fixed-size string event->device_class
> by copying device_class without checking the length."
> 
> Addresses-Coverity-ID: 139001 ("Copy into fixed size buffer")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/acpi/event.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/event.c b/drivers/acpi/event.c
> index 5a127f3f2d5c..47f21599f2ab 100644
> --- a/drivers/acpi/event.c
> +++ b/drivers/acpi/event.c
> @@ -131,8 +131,8 @@ int acpi_bus_generate_netlink_event(const char *device_class,
>  	event = nla_data(attr);
>  	memset(event, 0, sizeof(struct acpi_genl_event));
>  
> -	strcpy(event->device_class, device_class);
> -	strcpy(event->bus_id, bus_id);
> +	strscpy(event->device_class, device_class, sizeof(event->device_class));
> +	strscpy(event->bus_id, bus_id, sizeof(event->bus_id));
>  	event->type = type;
>  	event->data = data;
>  
> 

Applied, thanks!