linux-kernel - Re: [PATCH] Revert "PCI/LINK: Report degraded links via link bandwidth notification"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 May 2019 07:16:15 -0600
From:   Keith Busch <kbusch@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Alex G <mr.nuke.me@...il.com>, Lukas Wunner <lukas@...ner.de>,
        Alex Williamson <alex.williamson@...hat.com>,
        Austin Bolen <austin_bolen@...l.com>,
        Alexandru Gagniuc <alex_gagniuc@...lteam.com>,
        Keith Busch <keith.busch@...el.com>,
        Shyam Iyer <Shyam_Iyer@...l.com>,
        Sinan Kaya <okaya@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "PCI/LINK: Report degraded links via link
 bandwidth notification"

On Tue, Apr 30, 2019 at 09:12:49PM -0500, Bjorn Helgaas wrote:
> On Tue, Apr 30, 2019 at 12:18:13PM -0600, Keith Busch wrote:
> > On Tue, Apr 30, 2019 at 12:05:09PM -0600, Keith Busch wrote:
> > > On Tue, Apr 30, 2019 at 11:11:51AM -0500, Bjorn Helgaas wrote:
> > > > > I'm not convinced a revert is the best call.
> > > > 
> > > > I have very limited options at this stage of the release, but I'd be
> > > > glad to hear suggestions.  My concern is that if we release v5.1
> > > > as-is, we'll spend a lot of energy on those false positives.
> > > 
> > > May be too late now if the revert is queued up, but I think this feature
> > > should have been a default 'false' Kconfig bool rather than always on.
> 
> Since this feature currently just adds a message in dmesg, which we
> don't really consider a stable API, I think a Kconfig switch is a
> reasonable option.
> 
> If you send me a signed-off-by for the following patch, I can apply it:

Sounds good, I'll need to resend though since I messed up the Makefile:

> +obj-$(CONFIG_PCIE_BW)		:= bw_notification.o

    s/:=/+=