linux-kernel - Re: [PATCH v3 2/6] arm64: dts: msm8998: Add xo clock to gcc node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14d71a86-4bf7-b5f1-3efa-0938bd838ce3@codeaurora.org>
Date:   Wed, 1 May 2019 08:17:58 -0600
From:   Jeffrey Hugo <jhugo@...eaurora.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     agross@...nel.org, david.brown@...aro.org, marc.w.gonzalez@...e.fr,
        mturquette@...libre.com, sboyd@...nel.org, robh+dt@...nel.org,
        mark.rutland@....com, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/6] arm64: dts: msm8998: Add xo clock to gcc node

On 4/30/2019 9:35 PM, Bjorn Andersson wrote:
> On Tue 30 Apr 19:25 PDT 2019, Jeffrey Hugo wrote:
> 
>> GCC is a consumer of the xo clock.  Add a reference to the clock supplier
>> to the gcc node.
>>
>> Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org>
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> 
> (Although I prefer clock-names following clocks)

Huh, I didn't even realize I did that until you pointed it out.  Feel 
free to adjust when you apply, or if there is another spin I'll fix it.

> 
> Regards,
> Bjorn
> 
>> ---
>>   arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> index 574be78..9c88801 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> @@ -709,6 +709,8 @@
>>   			#reset-cells = <1>;
>>   			#power-domain-cells = <1>;
>>   			reg = <0x100000 0xb0000>;
>> +			clock-names = "xo";
>> +			clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>;
>>   		};
>>   
>>   		tlmm: pinctrl@...0000 {
>> -- 
>> Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
>> Qualcomm Technologies, Inc. is a member of the
>> Code Aurora Forum, a Linux Foundation Collaborative Project.
>>


-- 
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.