linux-kernel - [v4 1/2] device-dax: fix memory and resource leak if hotplug fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190501191846.12634-2-pasha.tatashin@soleen.com>
Date:   Wed,  1 May 2019 15:18:45 -0400
From:   Pavel Tatashin <pasha.tatashin@...een.com>
To:     pasha.tatashin@...een.com, jmorris@...ei.org, sashal@...nel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-nvdimm@...ts.01.org, akpm@...ux-foundation.org,
        mhocko@...e.com, dave.hansen@...ux.intel.com,
        dan.j.williams@...el.com, keith.busch@...el.com,
        vishal.l.verma@...el.com, dave.jiang@...el.com, zwisler@...nel.org,
        thomas.lendacky@....com, ying.huang@...el.com,
        fengguang.wu@...el.com, bp@...e.de, bhelgaas@...gle.com,
        baiyaowei@...s.chinamobile.com, tiwai@...e.de, jglisse@...hat.com,
        david@...hat.com
Subject: [v4 1/2] device-dax: fix memory and resource leak if hotplug fails

When add_memory() function fails, the resource and the memory should be
freed.

Fixes: c221c0b0308f ("device-dax: "Hotplug" persistent memory for use like normal RAM")

Signed-off-by: Pavel Tatashin <pasha.tatashin@...een.com>
Reviewed-by: Dave Hansen <dave.hansen@...el.com>
---
 drivers/dax/kmem.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c
index a02318c6d28a..4c0131857133 100644
--- a/drivers/dax/kmem.c
+++ b/drivers/dax/kmem.c
@@ -66,8 +66,11 @@ int dev_dax_kmem_probe(struct device *dev)
 	new_res->name = dev_name(dev);
 
 	rc = add_memory(numa_node, new_res->start, resource_size(new_res));
-	if (rc)
+	if (rc) {
+		release_resource(new_res);
+		kfree(new_res);
 		return rc;
+	}
 
 	return 0;
 }
-- 
2.21.0