linux-kernel - Re: [PATCH v3 2/4] add the buffer to the xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1556815933.4134.77.camel@linux.ibm.com>
Date:   Thu, 02 May 2019 12:52:13 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Prakhar Srivastava <prsriva02@...il.com>,
        linux-integrity@...r.kernel.org,
        linux-secuirty-module@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     ebiederm@...ssion.com, vgoyal@...hat.com, nayna@...ux.ibm.com
Subject: Re: [PATCH v3 2/4] add the buffer to the xattr

On Mon, 2019-04-29 at 14:47 -0700, Prakhar Srivastava wrote:
> From: Prakhar Srivastava <prsriva02@...il.com>
> 
> add the buffer to the xattr for a buffer case

Please write full patch descriptions, here and in the other patches,
explaining the current status with the motivation for the change.

> 
> Signed-off-by: Prakhar Srivastava <prsriva02@...il.com>
> ---

< snip >
>  
> @@ -630,17 +651,23 @@ static int process_buffer_measurement(const void *buff, int size,
>  	if (ret < 0)
>  		goto err_out;
>  
> -	ret = ima_store_template(entry, violation, NULL,
> +	if (action & IMA_MEASURE)
> +		ret = ima_store_template(entry, violation, NULL,
>  					buff, pcr);

Although scripts/Lindent has its problems, it does a good job with
code formatting.  There's no reason here for the line breakage.

Mimi