linux-kernel - RE: [PATCH v2 16/17] kernel/sysctl-test: Add null pointer test for sysctl.c:proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ECADFF3FD767C149AD96A924E7EA6EAF9770A3A0@USCULXMSG01.am.sony.com>
Date:   Thu, 2 May 2019 18:14:53 +0000
From:   <Tim.Bird@...y.com>
To:     <gregkh@...uxfoundation.org>, <brendanhiggins@...gle.com>
CC:     <frowand.list@...il.com>, <keescook@...gle.com>,
        <kieran.bingham@...asonboard.com>, <mcgrof@...nel.org>,
        <robh@...nel.org>, <sboyd@...nel.org>, <shuah@...nel.org>,
        <devicetree@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <kunit-dev@...glegroups.com>, <linux-doc@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>, <linux-kbuild@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
        <linux-nvdimm@...ts.01.org>, <linux-um@...ts.infradead.org>,
        <Alexander.Levin@...rosoft.com>, <amir73il@...il.com>,
        <dan.carpenter@...cle.com>, <dan.j.williams@...el.com>,
        <daniel@...ll.ch>, <jdike@...toit.com>, <joel@....id.au>,
        <julia.lawall@...6.fr>, <khilman@...libre.com>,
        <knut.omang@...cle.com>, <logang@...tatee.com>,
        <mpe@...erman.id.au>, <pmladek@...e.com>, <richard@....at>,
        <rientjes@...gle.com>, <rostedt@...dmis.org>,
        <wfg@...ux.intel.com>, <yzaikin@...gle.com>
Subject: RE: [PATCH v2 16/17] kernel/sysctl-test: Add null pointer test for
 sysctl.c:proc_dointvec()



> -----Original Message-----
> From: Greg KH 
> 
> On Wed, May 01, 2019 at 04:01:25PM -0700, Brendan Higgins wrote:
> > From: Iurii Zaikin <yzaikin@...gle.com>
> >
> > KUnit tests for initialized data behavior of proc_dointvec that is
> > explicitly checked in the code. Includes basic parsing tests including
> > int min/max overflow.
> >
> > Signed-off-by: Iurii Zaikin <yzaikin@...gle.com>
> > Signed-off-by: Brendan Higgins <brendanhiggins@...gle.com>
> > ---
> >  kernel/Makefile      |   2 +
> >  kernel/sysctl-test.c | 292
> +++++++++++++++++++++++++++++++++++++++++++
> >  lib/Kconfig.debug    |   6 +
> >  3 files changed, 300 insertions(+)
> >  create mode 100644 kernel/sysctl-test.c
> >
> > diff --git a/kernel/Makefile b/kernel/Makefile
> > index 6c57e78817dad..c81a8976b6a4b 100644
> > --- a/kernel/Makefile
> > +++ b/kernel/Makefile
> > @@ -112,6 +112,8 @@ obj-$(CONFIG_HAS_IOMEM) += iomem.o
> >  obj-$(CONFIG_ZONE_DEVICE) += memremap.o
> >  obj-$(CONFIG_RSEQ) += rseq.o
> >
> > +obj-$(CONFIG_SYSCTL_KUNIT_TEST) += sysctl-test.o
> 
> You are going to have to have a "standard" naming scheme for test
> modules, are you going to recommend "foo-test" over "test-foo"?  If so,
> that's fine, we should just be consistant and document it somewhere.
> 
> Personally, I'd prefer "test-foo", but that's just me, naming is hard...

My preference would be "test-foo" as well.  Just my 2 cents.
 -- Tim