linux-kernel - Re: [PATCH v3 1/2] prctl_set_mm: Refactor checks from validate_prctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190502205709.GD2488@uranus.lan>
Date:   Thu, 2 May 2019 23:57:09 +0300
From:   Cyrill Gorcunov <gorcunov@...il.com>
To:     Michal Koutný <mkoutny@...e.com>
Cc:     akpm@...ux-foundation.org, arunks@...eaurora.org, brgl@...ev.pl,
        geert+renesas@...der.be, ldufour@...ux.ibm.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        mguzik@...hat.com, mhocko@...nel.org, rppt@...ux.ibm.com,
        vbabka@...e.cz, ktkhai@...tuozzo.com
Subject: Re: [PATCH v3 1/2] prctl_set_mm: Refactor checks from
 validate_prctl_map

On Thu, May 02, 2019 at 02:52:02PM +0200, Michal Koutný wrote:
> Despite comment of validate_prctl_map claims there are no capability
> checks, it is not completely true since commit 4d28df6152aa ("prctl:
> Allow local CAP_SYS_ADMIN changing exe_file"). Extract the check out of
> the function and make the function perform purely arithmetic checks.
> 
> This patch should not change any behavior, it is mere refactoring for
> following patch.
> 
> v1, v2: ---
> v3: Remove unused mm variable from validate_prctl_map_addr
> 
> CC: Kirill Tkhai <ktkhai@...tuozzo.com>
> CC: Cyrill Gorcunov <gorcunov@...il.com>
> Signed-off-by: Michal Koutný <mkoutny@...e.com>
> Reviewed-by: Kirill Tkhai <ktkhai@...tuozzo.com>
Reviewed-by: Cyrill Gorcunov <gorcunov@...il.com>