linux-kernel - Re: [PATCH v1 3/4] powerpc/mm: Move book3s32 specifics in subdirectory mm/book3s64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 May 2019 13:43:00 +0200
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v1 3/4] powerpc/mm: Move book3s32 specifics in
 subdirectory mm/book3s64



Le 02/05/2019 à 13:32, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@....fr> writes:
> 
>> Several files in arch/powerpc/mm are only for book3S32. This patch
>> creates a subdirectory for them.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
>> ---
>>   arch/powerpc/mm/Makefile                            | 3 +--
>>   arch/powerpc/mm/book3s32/Makefile                   | 6 ++++++
>>   arch/powerpc/mm/{ => book3s32}/hash_low_32.S        | 0
>>   arch/powerpc/mm/{ => book3s32}/mmu_context_hash32.c | 0
>>   arch/powerpc/mm/{ => book3s32}/ppc_mmu_32.c         | 0
>>   arch/powerpc/mm/{ => book3s32}/tlb_hash32.c         | 0
>>   6 files changed, 7 insertions(+), 2 deletions(-)
>>   create mode 100644 arch/powerpc/mm/book3s32/Makefile
>>   rename arch/powerpc/mm/{ => book3s32}/hash_low_32.S (100%)
>>   rename arch/powerpc/mm/{ => book3s32}/mmu_context_hash32.c (100%)
>>   rename arch/powerpc/mm/{ => book3s32}/ppc_mmu_32.c (100%)
>>   rename arch/powerpc/mm/{ => book3s32}/tlb_hash32.c (100%)
> 
> I shortened them to:
> 
>    arch/powerpc/mm/{hash_low_32.S => book3s32/hash_low.S}
>    arch/powerpc/mm/{ppc_mmu_32.c => book3s32/mmu.c}

To be consistent with what you did in nohash/ dir, shouldn't we rename 
the above 'ppc.c' or 'ppc_32.c' instead of 'mmu.c' ?

Christophe

>    arch/powerpc/mm/{mmu_context_hash32.c => book3s32/mmu_context.c}
>    arch/powerpc/mm/{tlb_hash32.c => book3s32/tlb.c}
> 
> cheers
>