linux-kernel - re: serial: Add Milbeaut serial control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <246f81ba-0ed1-d5bc-1a48-bcf0fb2cc05e@canonical.com>
Date:   Thu, 2 May 2019 12:47:39 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Sugaya Taichi <sugaya.taichi@...ionext.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: re: serial: Add Milbeaut serial control

Hi,

Static analysis with Coverity has picked up an issue in commit:

commit ba44dc04300441b47618f9933bf36e75a280e5fe
Author: Sugaya Taichi <sugaya.taichi@...ionext.com>
Date:   Mon Apr 15 20:31:40 2019 +0900

    serial: Add Milbeaut serial control

In function mlb_usio_rx_chars() the u8 status is being bit-wise AND'd
with MLB_USIO_SSR_BRK (which is 1UL << 8) and hence the result is always
false, which looks incorrect to me.  Is this intentional?

Colin