linux-kernel - Re: [PATCH v4 net-next 00/12] NXP SJA1105 DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hrmXaAAepTrY-HfbrmZPVRf3Qg1-fA8EW4prwSkrGYogQ@mail.gmail.com>
Date:   Thu, 2 May 2019 19:31:50 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Florian Fainelli <f.fainelli@...il.com>, vivien.didelot@...il.com,
        Andrew Lunn <andrew@...n.ch>, netdev <netdev@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 net-next 00/12] NXP SJA1105 DSA driver

On Wed, 1 May 2019 at 06:44, David Miller <davem@...emloft.net> wrote:
>
> From: Vladimir Oltean <olteanv@...il.com>
> Date: Mon, 29 Apr 2019 03:16:54 +0300
>
> > This patchset adds a DSA driver for the SPI-controlled NXP SJA1105
> > switch.
>
> This patch series adds many whitespace errors, which are all reported
> by GIT when I try to apply your changes:
>
> Applying: lib: Add support for generic packing operations
> .git/rebase-apply/patch:176: new blank line at EOF.
> +
> .git/rebase-apply/patch:480: new blank line at EOF.
> +
> warning: 2 lines add whitespace errors.
> Applying: net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch
> .git/rebase-apply/patch:102: new blank line at EOF.
> +
> .git/rebase-apply/patch:117: new blank line at EOF.
> +
> .git/rebase-apply/patch:262: new blank line at EOF.
> +
> .git/rebase-apply/patch:867: new blank line at EOF.
> +
> .git/rebase-apply/patch:2905: new blank line at EOF.
> +
> warning: squelched 2 whitespace errors
> warning: 7 lines add whitespace errors.
> Applying: net: dsa: sja1105: Add support for FDB and MDB management
> .git/rebase-apply/patch:81: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: net: dsa: sja1105: Error out if RGMII delays are requested in DT
> Applying: ether: Add dedicated Ethertype for pseudo-802.1Q DSA tagging
> Applying: net: dsa: sja1105: Add support for VLAN operations
> .git/rebase-apply/patch:359: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: net: dsa: sja1105: Add support for ethtool port counters
> .git/rebase-apply/patch:474: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: net: dsa: sja1105: Add support for configuring address aging time
> Applying: net: dsa: sja1105: Prevent PHY jabbering during switch reset
> Applying: net: dsa: sja1105: Reject unsupported link modes for AN
> Applying: Documentation: net: dsa: Add details about NXP SJA1105 driver
> .git/rebase-apply/patch:200: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: dt-bindings: net: dsa: Add documentation for NXP SJA1105 driver
> .git/rebase-apply/patch:178: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.

Wow I am sorry, Gmail apparently moved your reply to spam and I only
got it when I posted my message just now.
Do you know what causes these whitespace errors, so I can avoid them
next time? I think I'm generating my patches rather normally, with
$(git format-patch -12 --subject-prefix="PATCH v4 net-next"
--cover-letter).

Thanks,
-Vladimir