lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190503065353.GZ26546@localhost> Date: Fri, 3 May 2019 08:53:53 +0200 From: Johan Hovold <johan@...nel.org> To: "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com> Cc: peter_hong@...tek.com.tw, johan@...nel.org, gregkh@...uxfoundation.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@...il.com> Subject: Re: [PATCH V9 1/4] USB: serial: f81232: fix interrupt worker not stop On Tue, Apr 30, 2019 at 09:22:29AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81232 will use interrupt worker to handle MSR change. > This patch will fix the issue that interrupt work should stop > in close() and suspend(). > > Cc: Johan Hovold <johan@...nel.org> > Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@...il.com> > +static int f81232_resume(struct usb_serial *serial) > +{ > + struct usb_serial_port *port = serial->port[0]; > + int result; > + > + if (tty_port_initialized(&port->port)) { > + result = usb_submit_urb(port->interrupt_in_urb, GFP_NOIO); > + if (result) { > + dev_err(&port->dev, "submit interrupt urb failed: %d", > + result); I added the missing '\n' to the error message. > + return result; > + } > + } > + > + return usb_serial_generic_resume(serial); > +} This also fixes the issue with interrupt events not being received after a suspend cycle, so I added that to the commit message. Johan
Powered by blists - more mailing lists