linux-kernel - Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c9a58611-13e2-8e13-b573-b504032c017c@suse.de>
Date:   Fri, 3 May 2019 10:05:03 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Willem Riede <osst@...de.org>
Cc:     Christoph Hellwig <hch@....de>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Lee Duncan <lduncan@...e.com>, Chris Leech <cleech@...hat.com>,
        Doug Gilbert <dgilbert@...erlog.com>,
        Jens Axboe <axboe@...nel.dk>,
        Kai Mäkisara <Kai.Makisara@...umbus.fi>,
        linux-scsi@...r.kernel.org, open-iscsi@...glegroups.com,
        osst-users@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
        Chriosstoph Hellwig <hch@...st.de>
Subject: Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

On 5/2/19 9:55 PM, Willem Riede wrote:
> On Thu, May 2, 2019 at 7:19 AM Hannes Reinecke <hare@...e.de 
> <mailto:hare@...e.de>> wrote:
> 
>     On 5/2/19 2:53 PM, Christoph Hellwig wrote:
>      > On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote:
>      >> On 5/1/19 6:14 PM, Christoph Hellwig wrote:
>      >>> osst.c is the only osst file missing licensing information.  Add a
>      >>> GPLv2 tag for the default kernel license.
>      >>>
>      >>> Signed-off-by: Chriosstoph Hellwig <hch@...st.de
>     <mailto:hch@...st.de>>
>      >
>      > FYI, my s/st/osst/ on the commit message message up my signoff, this
>      > should be:
>      >
>      > Signed-off-by: Christoph Hellwig <hch@....de <mailto:hch@....de>>
>      >
>     Maybe it's time to kill osst.c for good ...
> 
> 
> Yes. I've been thinking about doing just that. The devices it supports 
> are now thoroughly obsolete. The manufacturer has gone out of business. 
> All my test drives have broken down over time, so I can't even test any 
> changes any more.
> 
Just when I thought to reach out to you :-)

Thing is, we've done numerous changes to the 'st' driver in the course 
of the years, most of which seem to have avoided osst :-(

So what's your suggestion here?
Just drop it completely?
Or can we somehow fold the OnStream-specific things back into st.c?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)