lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJ2_jOEBDyG_7THdbGzny3gAmijGSQGV7eUO8MBwQaTgqKdN5g@mail.gmail.com> Date: Fri, 3 May 2019 16:52:46 +0530 From: Yash Shah <yash.shah@...ive.com> To: "Andrew F. Davis" <afd@...com> Cc: linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org, Palmer Dabbelt <palmer@...ive.com>, Paul Walmsley <paul.walmsley@...ive.com>, linux-kernel@...r.kernel.org, aou@...s.berkeley.edu, mark.rutland@....com, robh+dt@...nel.org, Sachin Ghadi <sachin.ghadi@...ive.com> Subject: Re: [PATCH v2 2/2] RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs On Thu, May 2, 2019 at 7:07 PM Andrew F. Davis <afd@...com> wrote: > > On 5/2/19 6:34 AM, Yash Shah wrote: > > The driver currently supports only SiFive FU540-C000 platform. > > > > The initial version of L2 cache controller driver includes: > > - Initial configuration reporting at boot up. > > - Support for ECC related functionality. > > > > Signed-off-by: Yash Shah <yash.shah@...ive.com> > > --- > > arch/riscv/mm/Makefile | 1 + > > arch/riscv/mm/sifive_l2_cache.c | 221 ++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 222 insertions(+) > > create mode 100644 arch/riscv/mm/sifive_l2_cache.c > > > > diff --git a/arch/riscv/mm/Makefile b/arch/riscv/mm/Makefile > > index eb22ab4..1523ee5 100644 > > --- a/arch/riscv/mm/Makefile > > +++ b/arch/riscv/mm/Makefile > > @@ -3,3 +3,4 @@ obj-y += fault.o > > obj-y += extable.o > > obj-y += ioremap.o > > obj-y += cacheflush.o > > +obj-y += sifive_l2_cache.o > > diff --git a/arch/riscv/mm/sifive_l2_cache.c b/arch/riscv/mm/sifive_l2_cache.c > > new file mode 100644 > > index 0000000..923ab34 > > --- /dev/null > > +++ b/arch/riscv/mm/sifive_l2_cache.c > > @@ -0,0 +1,221 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * SiFive L2 cache controller Driver > > + * > > + * Copyright (C) 2018-2019 SiFive, Inc. > > + * > > + */ ... > > +static unsigned int l2_datfail_count(void) > > +{ > > + return readl(l2_base + SIFIVE_L2_DATECCFAIL_COUNT); > > +} > > Do you really need all these single line functions? Below in several > spots you use the readl directly, just do that everywhere. Ok. Will remove these single line functions. Thanks for your comments. - Yash > > Andrew >
Powered by blists - more mailing lists