linux-kernel - Re: [PATCH] net: macb: remove redundant struct phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190503122910.GB1941@lunn.ch>
Date:   Fri, 3 May 2019 14:29:10 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Nicolas Ferre <nicolas.ferre@...rochip.com>
Cc:     Claudiu Beznea <claudiu.beznea@...rochip.com>,
        linux-arm-kernel@...ts.infradead.org,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        harini.katakam@...inx.com,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-kernel@...r.kernel.org, michal.simek@...inx.com
Subject: Re: [PATCH] net: macb: remove redundant struct phy_device declaration

On Fri, May 03, 2019 at 12:36:28PM +0200, Nicolas Ferre wrote:
> While moving the chunk of code during 739de9a1563a
> ("net: macb: Reorganize macb_mii bringup"), the declaration of
> struct phy_device declaration was kept. It's not useful in this
> function as we alrady have a phydev pointer.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew