linux-kernel - Re: [PATCH] HID: rmi: fix devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1905031440570.10635@cbobk.fhfr.pm>
Date:   Fri, 3 May 2019 14:42:18 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Fabien DESSENNE <fabien.dessenne@...com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter

On Fri, 3 May 2019, Fabien DESSENNE wrote:

> >> -	ret = devm_add_action_or_reset(&hdev->dev, &rmi_irq_teardown, hdata);
> >> +	ret = devm_add_action_or_reset(&hdev->dev, rmi_irq_teardown, hdata);
> > Why do you think this is wrong C?
> 
> Because I was not aware that both func and &func refer to the same 
> function pointer.
> 
> Now I know :)

Yup, it's defined in 6.3.2.1.4 in C99.

-- 
Jiri Kosina
SUSE Labs