linux-kernel - [tip:sched/core 24/27] kernel/power/hibernate.c:284:10: error: implicit declaration of function 'suspend_disable_secondary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <201905032142.YVCdv1Lz%lkp@intel.com>
Date:   Fri, 3 May 2019 21:00:58 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Nicholas Piggin <npiggin@...il.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        tipbuild@...or.com, Ingo Molnar <mingo@...nel.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: [tip:sched/core 24/27] kernel/power/hibernate.c:284:10: error:
 implicit declaration of function 'suspend_disable_secondary_cpus'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
head:   65874bd36e6ae3028539e989bfb5c28ad457368e
commit: c2cb30bfceceba8a2a0d5713230a250dd6140e22 [24/27] power/suspend: Add function to disable secondaries for suspend
config: x86_64-randconfig-l2-05031806 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        git checkout c2cb30bfceceba8a2a0d5713230a250dd6140e22
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/power/hibernate.c: In function 'create_image':
>> kernel/power/hibernate.c:284:10: error: implicit declaration of function 'suspend_disable_secondary_cpus' [-Werror=implicit-function-declaration]
     error = suspend_disable_secondary_cpus();
             ^
>> kernel/power/hibernate.c:326:2: error: implicit declaration of function 'suspend_enable_secondary_cpus' [-Werror=implicit-function-declaration]
     suspend_enable_secondary_cpus();
     ^
   cc1: some warnings being treated as errors

vim +/suspend_disable_secondary_cpus +284 kernel/power/hibernate.c

   260	
   261	/**
   262	 * create_image - Create a hibernation image.
   263	 * @platform_mode: Whether or not to use the platform driver.
   264	 *
   265	 * Execute device drivers' "late" and "noirq" freeze callbacks, create a
   266	 * hibernation image and run the drivers' "noirq" and "early" thaw callbacks.
   267	 *
   268	 * Control reappears in this routine after the subsequent restore.
   269	 */
   270	static int create_image(int platform_mode)
   271	{
   272		int error;
   273	
   274		error = dpm_suspend_end(PMSG_FREEZE);
   275		if (error) {
   276			pr_err("Some devices failed to power down, aborting hibernation\n");
   277			return error;
   278		}
   279	
   280		error = platform_pre_snapshot(platform_mode);
   281		if (error || hibernation_test(TEST_PLATFORM))
   282			goto Platform_finish;
   283	
 > 284		error = suspend_disable_secondary_cpus();
   285		if (error || hibernation_test(TEST_CPUS))
   286			goto Enable_cpus;
   287	
   288		local_irq_disable();
   289	
   290		system_state = SYSTEM_SUSPEND;
   291	
   292		error = syscore_suspend();
   293		if (error) {
   294			pr_err("Some system devices failed to power down, aborting hibernation\n");
   295			goto Enable_irqs;
   296		}
   297	
   298		if (hibernation_test(TEST_CORE) || pm_wakeup_pending())
   299			goto Power_up;
   300	
   301		in_suspend = 1;
   302		save_processor_state();
   303		trace_suspend_resume(TPS("machine_suspend"), PM_EVENT_HIBERNATE, true);
   304		error = swsusp_arch_suspend();
   305		/* Restore control flow magically appears here */
   306		restore_processor_state();
   307		trace_suspend_resume(TPS("machine_suspend"), PM_EVENT_HIBERNATE, false);
   308		if (error)
   309			pr_err("Error %d creating hibernation image\n", error);
   310	
   311		if (!in_suspend) {
   312			events_check_enabled = false;
   313			clear_free_pages();
   314		}
   315	
   316		platform_leave(platform_mode);
   317	
   318	 Power_up:
   319		syscore_resume();
   320	
   321	 Enable_irqs:
   322		system_state = SYSTEM_RUNNING;
   323		local_irq_enable();
   324	
   325	 Enable_cpus:
 > 326		suspend_enable_secondary_cpus();
   327	
   328	 Platform_finish:
   329		platform_finish(platform_mode);
   330	
   331		dpm_resume_start(in_suspend ?
   332			(error ? PMSG_RECOVER : PMSG_THAW) : PMSG_RESTORE);
   333	
   334		return error;
   335	}
   336	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (26791 bytes)