[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190503135725.9959-1-dev@pschenker.ch>
Date: Fri, 3 May 2019 15:57:23 +0200
From: Philippe Schenker <dev@...henker.ch>
To: linux-iio@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
Stefan Agner <stefan@...er.ch>,
Hartmut Knaack <knaack.h@....de>,
Lars-Peter Clausen <lars@...afoo.de>,
Peter Meerwald-Stadler <pmeerw@...erw.net>
Cc: dev@...henker.ch,
Philippe Schenker <philippe.schenker@...adex.com>,
Max Krummenacher <max.krummenacher@...adex.com>,
Alexandre Torgue <alexandre.torgue@...com>,
linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org
Subject: [PATCH 1/3] iio: stmpe-adc: Remove unnecessary assignment
From: Philippe Schenker <philippe.schenker@...adex.com>
Remove unnecessary assignment. This could potentially cause an issue, if
the wait function runs into a timeout. Furthermore is this assignment also
not there in stmpe_read_temp()
Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
---
drivers/iio/adc/stmpe-adc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c
index 37f4b74a5d32..87141177fbda 100644
--- a/drivers/iio/adc/stmpe-adc.c
+++ b/drivers/iio/adc/stmpe-adc.c
@@ -78,8 +78,6 @@ static int stmpe_read_voltage(struct stmpe_adc *info,
stmpe_reg_write(info->stmpe, STMPE_REG_ADC_CAPT,
STMPE_ADC_CH(info->channel));
- *val = info->value;
-
ret = wait_for_completion_interruptible_timeout
(&info->completion, STMPE_ADC_TIMEOUT);
--
2.21.0
Powered by blists - more mailing lists