lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190503031020.GV3845@vkoul-mobl.Dlink> Date: Fri, 3 May 2019 08:40:20 +0530 From: Vinod Koul <vkoul@...nel.org> To: Bjorn Andersson <bjorn.andersson@...aro.org> Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Stanimir Varbanov <svarbanov@...sol.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 1/3] PCI: qcom: Use clk_bulk API for 2.4.0 controllers On 02-05-19, 08:00, Bjorn Andersson wrote: > On Thu 02 May 04:53 PDT 2019, Vinod Koul wrote: > > On 01-05-19, 17:19, Bjorn Andersson wrote: > [..] > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > > index 0ed235d560e3..d740cbe0e56d 100644 > > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > > @@ -112,10 +112,10 @@ struct qcom_pcie_resources_2_3_2 { > > > struct regulator_bulk_data supplies[QCOM_PCIE_2_3_2_MAX_SUPPLY]; > > > }; > > > > > > +#define QCOM_PCIE_2_4_0_MAX_CLOCKS 3 > > > > empty line after the define please > > > > This follows the style of QCOM_PCIE_2_3_2_MAX_SUPPLY one block up, so > I think this is the way we want it. Okay sounds fine to me > > > > struct qcom_pcie_resources_2_4_0 { > [..] > > > > > > rest lgtm: > > > > Reviewed-by: Vinod Koul <vkoul@...nel.org> > > > > Thanks! > > Regards, > Bjorn -- ~Vinod
Powered by blists - more mailing lists