linux-kernel - Re: [PATCH v3] x86: mm: Do not use set_{pud,pmd}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10184ec0-008c-f9a5-a043-0fe0ce211e4d@amd.com>
Date:   Fri, 3 May 2019 15:28:27 +0000
From:   "Singh, Brijesh" <brijesh.singh@....com>
To:     Dave Hansen <dave.hansen@...el.com>,
        "x86@...nel.org" <x86@...nel.org>
CC:     "Singh, Brijesh" <brijesh.singh@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Dan Williams <dan.j.williams@...el.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>
Subject: Re: [PATCH v3] x86: mm: Do not use set_{pud,pmd}_safe when splitting
 the large page

Hi Boris,

On 4/17/19 12:24 PM, Dave Hansen wrote:
...

> 
> The comment here is missing one key point:
> kernel_physical_mapping_init() can only be used to populate non-present
> entries.  It kinda infers that from "Create...", but I really think we
> need to be explicit.
> 
> Anyway, it's better than it was, and it does fix a bug, so:
> 
> Reviewed-by: Dave Hansen <dave.hansen@...el.com>
> 
> But please flesh out that comment if you do another version for some reason.
> 

Can you please pick this patch? Or do you want me to resend it ?
It's fixing a bug seen in SEV guest.

-Brijesh